[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87389itk0y.fsf@sejong.aot.lge.com>
Date: Mon, 17 Nov 2014 15:31:57 +0900
From: Namhyung Kim <namhyung@...nel.org>
To: Andi Kleen <andi@...stfloor.org>
Cc: jolsa@...hat.com, linux-kernel@...r.kernel.org, acme@...nel.org,
Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/8] perf, tools: Add --branch-history option to report
On Wed, 12 Nov 2014 01:05:05 +0100, Andi Kleen wrote:
>> And please also add a new CCKEY_SRCLINE if you print srcline with the
>> callchains so that users can give "-g srcline" if they want (regardless
>> of the branch history feature).
>
> That would be largely identical to CCKEY_ADDRESS
> except for the case of two calls to the same function from
> the same line. Probably not worth adding?
For sorting, yes, it'd be almost identical. But what I'm saying is for
printing - IOW print callchain entries with symbol and srcline (for
normal perf report too).
Anyway, I think it'd be a separate patch(set).
Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists