linux-kernel - Re: [PATCH 2/8] perf, tools: Add --branch-history option to report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141118020145.GF12538@two.firstfloor.org>
Date:	Tue, 18 Nov 2014 03:01:45 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Andi Kleen <andi@...stfloor.org>, jolsa@...hat.com,
	linux-kernel@...r.kernel.org, acme@...nel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/8] perf, tools: Add --branch-history option to report

On Mon, Nov 17, 2014 at 03:31:57PM +0900, Namhyung Kim wrote:
> On Wed, 12 Nov 2014 01:05:05 +0100, Andi Kleen wrote:
> >> And please also add a new CCKEY_SRCLINE if you print srcline with the
> >> callchains so that users can give "-g srcline" if they want (regardless
> >> of the branch history feature).
> >
> > That would be largely identical to CCKEY_ADDRESS 
> > except for the case of two calls to the same function from
> > the same line. Probably not worth adding?
> 
> For sorting, yes, it'd be almost identical.  But what I'm saying is for
> printing - IOW print callchain entries with symbol and srcline (for
> normal perf report too).

But I thought the key is only for sorting?

I already added an option to print the src line and it should
work for normal perf report.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/