linux-kernel - Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141119101420.GX22111@sirena.org.uk>
Date:	Wed, 19 Nov 2014 10:14:20 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Gyungoh Yoo <gyungoh@...il.com>
Cc:	sameo@...ux.intel.com, lee.jones@...aro.org, jg1.han@...sung.com,
	cooloney@...il.com, lgirdwood@...il.com, jack.yoo@...worksinc.com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	grant.likely@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	pawel.moll@....com, heiko@...ech.de, jason@...edaemon.net,
	shawn.guo@...escale.com, treding@...dia.com,
	florian.vaussard@...l.ch, trivial@...nel.org, linux@...ck-us.net,
	andrew@...n.ch, jic23@...nel.org
Subject: Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree
 structure

On Wed, Nov 19, 2014 at 04:39:54PM +0900, Gyungoh Yoo wrote:

> If of_match and regulators_node are assigned, don't I need to
> call of_regulator_match()? Does regulator_register() call it internally?
> So can I write code like below?
> 
> static const struct regulator_desc sky81452_reg = {
> 	.name = "LOUT",
> 	.of_match = of_match_ptr("lout"),
> 	.regulators_node = of_match_ptr("regulator"),
> 	.ops = &sky81452_reg_ops,
> 	...
> };

> 	config.regmap = dev_get_drvdata(dev->parent);
> 
> 	rdev = devm_regulator_register(dev, &sky81452_reg, &config);

Yes, exactly.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)