linux-kernel - Re: [RESUBMIT PATCH v7 4/9] devicetree: backlight: Add new SKY81452 backlight binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141125014749.GA28978@jack-ThinkPad-T520>
Date:	Tue, 25 Nov 2014 10:47:49 +0900
From:	Gyungoh Yoo <gyungoh@...il.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	sameo@...ux.intel.com, jg1.han@...sung.com, cooloney@...il.com,
	broonie@...nel.org, lgirdwood@...il.com, jack.yoo@...worksinc.com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	grant.likely@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	pawel.moll@....com, heiko@...ech.de, jason@...edaemon.net,
	shawn.guo@...escale.com, treding@...dia.com,
	florian.vaussard@...l.ch, trivial@...nel.org, linux@...ck-us.net,
	andrew@...n.ch, jic23@...nel.org
Subject: Re: [RESUBMIT PATCH v7 4/9] devicetree: backlight: Add new SKY81452
 backlight binding

On Mon, Nov 17, 2014 at 12:23:33PM +0000, Lee Jones wrote:
> On Mon, 17 Nov 2014, gyungoh@...il.com wrote:
> 
> > From: Gyungoh Yoo <jack.yoo@...worksinc.com>
> > 
> > Signed-off-by: Gyungoh Yoo <jack.yoo@...worksinc.com>
> > ---
> > Changes v7:
> > Nothing
> > 
> > Changes v6:
> > Nothing
> > 
> > Changes v5:
> > Nothing
> > 
> > Changes v4:
> > Nothing
> > 
> > Changes v3:
> > Nothing
> > 
> > Changes v2:
> > Added reg attribute for I2C slave address
> > 
> >  .../video/backlight/sky81452-backlight.txt         | 24 ++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> > new file mode 100644
> > index 0000000..2c2d947
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> > @@ -0,0 +1,24 @@
> > +SKY81452-backlight bindings
> > +
> > +Required properties:
> > +- compatible		: Must be "skyworks,sky81452-backlight"
> > +
> > +Optional properties:
> > +- name			: Name of backlight device. Default is 'lcd-backlight'.
> > +- gpio-enable		: GPIO to use to EN pin.
> > +- enable		: Enable mask for current sink channel 1 to 6.
> > +- ignore-pwm		: Ignore both PWM input
> > +- dpwm-mode		: Enable DPWM dimming mode, otherwise Analog dimming mode
> > +- phase-shift		: Enable phase shift mode
> > +- ovp-level		: Over-voltage protection level. Should be between 14 or 28V.
> > +- short-detection-threshold	: It should be one of 4, 5, 6 and 7V.
> > +- boost-current-limit	: It should be one of 800, 1100 and 1500mA.
> 
> These are going to need some serious reviewing from the DT guys.  Each
> property should either have a vendor prefix or be made generic and
> placed in the generic DT documentation for the subsystem.  The name
> 'enable' is far to generic we don't tend to put masks in DT.  There
> is already a generic property for GPIO enable pins.

I see. I will rename the properties with the vendor prefix
and modify the name for GPIO enable pin to use 'gpios'

> 
> > +Example:
> > +
> > +	backlight {
> > +		compatible = "skyworks,sky81452-backlight";
> > +		name = "pwm-backlight";
> > +		enable = <0x3F>;
> 
> Lower case.
> 
> > +		ignore-pwm;
> 
> You should probably demonstrate more of your properties here.

I will make up the example.
Thank you for your comments.

> 
> > +	};
> 
> -- 
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/