| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Nov 2014 15:56:46 +0100 From: Julien CHAUVEAU <julien.chauveau@...-technologies.fr> To: David Airlie <airlied@...ux.ie>, Rob Clark <robdclark@...il.com>, dri-devel@...ts.freedesktop.org (open list:DRM DRIVERS), linux-kernel@...r.kernel.org (open list) Cc: Julien CHAUVEAU <julien.chauveau@...-technologies.fr> Subject: [PATCH v2] drm/tilcdc: add missing clk_put in tilcdc_unload() We need to call clk_put on display clock, in the same way as functional clock. Also remove the check for priv->clk, since clk_put() is safe against NULL pointers. Signed-off-by: Julien CHAUVEAU <julien.chauveau@...-technologies.fr> --- Changes since v1: - remove the check for priv->clk, as suggested by Felipe Balbi drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 79a34cb..b0c9687 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -136,8 +136,8 @@ static int tilcdc_unload(struct drm_device *dev) CPUFREQ_TRANSITION_NOTIFIER); #endif - if (priv->clk) - clk_put(priv->clk); + clk_put(priv->disp_clk); + clk_put(priv->clk); if (priv->mmio) iounmap(priv->mmio); -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists