linux-kernel - Re: [PATCH 1/3] mfd: cros_ec: Add Chrome OS EC userspace device interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOesGMhaSmjcyzNuCCN_avb_DNk130KuGu5ByjML4gL5aA8TwQ@mail.gmail.com>
Date:	Wed, 19 Nov 2014 12:45:41 -0800
From:	Olof Johansson <olof@...om.net>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	Lee Jones <lee.jones@...aro.org>,
	Doug Anderson <dianders@...omium.org>,
	Bill Richardson <wfrichar@...omium.org>,
	Simon Glass <sjg@...gle.com>,
	Gwendal Grignou <gwendal@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] mfd: cros_ec: Add Chrome OS EC userspace device interface

On Wed, Nov 19, 2014 at 10:37 AM, Javier Martinez Canillas
<javier.martinez@...labora.co.uk> wrote:
> Hello Alan,
>
> Thanks a lot for your feedback.
>
> On 11/18/2014 06:00 PM, One Thousand Gnomes wrote:
>>> +#ifdef CONFIG_COMPAT
>>> +struct compat_cros_ec_command {
>>> +    uint32_t version;
>>> +    uint32_t command;
>>> +    compat_uptr_t outdata;
>>> +    uint32_t outsize;
>>> +    compat_uptr_t indata;
>>> +    uint32_t insize;
>>> +    uint32_t result;
>>> +};
>>> +
>>> +struct compat_cros_ec_readmem {
>>> +    uint32_t offset;
>>> +    uint32_t bytes;
>>> +    compat_uptr_t buffer;
>>> +};
>>>
>>
>> This is a new API - arrange them to be 64bit safe and properly padded,
>> there is no excuse for needing compat crap except for legacy interfaces
>> you can't fix.
>>
>
> Is true that this is a new API for mainline but there is a lot of ChromeOS
> installations that depends on this API which means that just replacing the
> kernel with a mainline one there, will break existing user-space programs.

I think we can deal with that, at least if we pick new ioctl numbers
so we can tell from the userspace tool which interface is in use
during transition.

> But I understand that since those binaries were using a non-ustream kernel
> it is expected that the kernel API could be changed.
>
> I think it would be great to keep existing binaries working but if changing
> the API is required, then I can certainly do that when doing a re-spin.

I think there's some value in that, but i'm also somewhat embarrassed
to have missed this aspect when doing internal review, and do agree
with Alan. :) And we have only a few tools that use this interface so
we should be able to cope with it.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/