linux-kernel - Re: [PATCHv4 1/1] thermal: of: improve of-thermal sensor registration API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141120134950.GA24778@developer>
Date:	Thu, 20 Nov 2014 09:49:52 -0400
From:	Eduardo Valentin <edubezval@...il.com>
To:	Mikko Perttunen <mikko.perttunen@...si.fi>
Cc:	Linux PM <linux-pm@...r.kernel.org>,
	Caesar Wang <caesar.wang@...k-chips.com>,
	Wei Ni <wni@...dia.com>,
	Lukasz Majewski <l.majewski@...sung.com>,
	Alexandre Courbot <gnurou@...il.com>,
	devicetree@...r.kernel.org, Grant Likely <grant.likely@...aro.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Jean Delvare <jdelvare@...e.de>, linux-kernel@...r.kernel.org,
	linux-tegra@...r.kernel.org, lm-sensors@...sensors.org,
	Rob Herring <robh+dt@...nel.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCHv4 1/1] thermal: of: improve of-thermal sensor
 registration API

Mikko,

On Wed, Nov 19, 2014 at 05:43:20PM +0200, Mikko Perttunen wrote:
> On 11/19/2014 05:41 PM, Mikko Perttunen wrote:
> > On 11/18/2014 04:39 PM, Eduardo Valentin wrote:
> >> Different drivers request API extensions in of-thermal. For this reason,
> >> additional callbacks are required to fit the new drivers needs.
> >>
> >> The current API implementation expects the registering sensor driver
> >> to provide a get_temp and get_trend callbacks as function parameters.
> >> As the amount of callbacks is growing, this patch changes the existing
> >> implementation to use a .ops field to hold all the of thermal callbacks
> >> to sensor drivers.
> >>
> >> This patch also changes the existing of-thermal users to fit the new
> >> API design. No functional change is introduced in this patch.
> >>
> >> Cc: Alexandre Courbot <gnurou@...il.com>
> >> Cc: devicetree@...r.kernel.org
> >> Cc: Grant Likely <grant.likely@...aro.org>
> >> Cc: Guenter Roeck <linux@...ck-us.net>
> >> Cc: Jean Delvare <jdelvare@...e.de>
> >> Cc: linux-kernel@...r.kernel.org
> >> Cc: linux-pm@...r.kernel.org
> >> Cc: linux-tegra@...r.kernel.org
> >> Cc: lm-sensors@...sensors.org
> >> Cc: Rob Herring <robh+dt@...nel.org>
> >> Cc: Stephen Warren <swarren@...dotorg.org>
> >> Cc: Thierry Reding <thierry.reding@...il.com>
> >> Cc: Zhang Rui <rui.zhang@...el.com>
> >> Reviewed-by: Lukasz Majewski <l.majewski@...sung.com>
> >> Signed-off-by: Eduardo Valentin <edubezval@...il.com>
> >> ---
> >>   drivers/hwmon/lm75.c                               |  9 +++--
> >>   drivers/hwmon/ntc_thermistor.c                     |  6 +++-
> >>   drivers/hwmon/tmp102.c                             |  6 +++-
> >>   drivers/thermal/of-thermal.c                       | 40
> >> ++++++++++------------
> >>   drivers/thermal/tegra_soctherm.c                   |  7 ++--
> >>   drivers/thermal/ti-soc-thermal/ti-thermal-common.c |  8 +++--
> >>   include/linux/thermal.h                            | 24 +++++++++----
> >>   7 files changed, 63 insertions(+), 37 deletions(-)
> >> ---
> >> Difference from V3:
> >>    - Keep the same behavior regarding callback checks.
> >>      Change in behavior may be sent in a separate patch.
> >> Difference from V2:
> >>    - Fix wrong assignment in tegra driver.
> >> Difference from V1:
> >>    - Fix error handling when .get_trend is not provided.
> >>
> >> @@ -356,8 +356,8 @@ thermal_zone_of_add_sensor(struct device_node *zone,
> >>    *             than one sensors
> >>    * @data: a private pointer (owned by the caller) that will be passed
> >>    *        back, when a temperature reading is needed.
> >> - * @get_temp: a pointer to a function that reads the sensor temperature.
> >> - * @get_trend: a pointer to a function that reads the sensor
> >> temperature trend.
> >> + * @ops: struct thermal_zone_of_device *. Must contain at least
> >> .get_trend and
> >> + *       .get_temp.
> >
> > This comment seems to be incorrect, as .get_trend is optional.
> 
> Also, the parameter is of type struct thermal_zone_of_device_ops *, not 
> just thermal_zone_of_device.
> 
> >
> >>    *
> >>    * This function will search the list of thermal zones described in
> >> device
> >>    * tree and look for the zone that refer to the sensor device
> >> pointed by
> >
> > With that minor one fixed,
> >
> > Tested-by: Mikko Perttunen <mikko.perttunen@...si.fi>
> > Reviewed-by: Mikko Perttunen <mikko.perttunen@...si.fi>

All the comments fixed now. Thanks for reviewing and testing.

> >
> > Cheers,
> > Mikko
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Cheers,

Eduardo Valentin

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)