linux-kernel - Re: [PATCHv4 1/1] thermal: of: improve of-thermal sensor registration API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 20 Nov 2014 09:52:32 -0400
From:	Eduardo Valentin <edubezval@...il.com>
To:	Alexandre Courbot <gnurou@...il.com>
Cc:	Linux PM <linux-pm@...r.kernel.org>,
	Caesar Wang <caesar.wang@...k-chips.com>,
	Wei Ni <wni@...dia.com>,
	Lukasz Majewski <l.majewski@...sung.com>,
	Mikko Perttunen <mikko.perttunen@...si.fi>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Grant Likely <grant.likely@...aro.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Jean Delvare <jdelvare@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	lm-sensors@...sensors.org, Rob Herring <robh+dt@...nel.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCHv4 1/1] thermal: of: improve of-thermal sensor
 registration API

Alexander,

On Wed, Nov 19, 2014 at 05:06:24PM +0900, Alexandre Courbot wrote:
> On Tue, Nov 18, 2014 at 11:39 PM, Eduardo Valentin <edubezval@...il.com> wrote:
> > Different drivers request API extensions in of-thermal. For this reason,
> > additional callbacks are required to fit the new drivers needs.
> >
> > The current API implementation expects the registering sensor driver
> > to provide a get_temp and get_trend callbacks as function parameters.
> > As the amount of callbacks is growing, this patch changes the existing
> > implementation to use a .ops field to hold all the of thermal callbacks
> > to sensor drivers.
> >
> > This patch also changes the existing of-thermal users to fit the new
> > API design. No functional change is introduced in this patch.
> 
> A good idea even if no ops were to be added!
> 
> Reviewed-by: Alexandre Courbot <acourbot@...dia.com>

Thanks for reviewing.

Eduardo Valentin

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)