linux-kernel - [PATCH v2] mm/zsmalloc: avoid duplicate assignment of prev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Nov 2014 21:43:23 +0800
From:	Mahendran Ganesh <opensource.ganesh@...il.com>
To:	minchan@...nel.org, ngupta@...are.org, iamjoonsoo.kim@....com,
	ddstreet@...e.org
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Mahendran Ganesh <opensource.ganesh@...il.com>
Subject: [PATCH v2] mm/zsmalloc: avoid duplicate assignment of prev_class

In zs_create_pool(), prev_class is assigned (ZS_SIZE_CLASSES - 1)
times. And the prev_class only references to the previous size_class.
So we do not need unnecessary assignement.

This patch assigns *prev_class* when a new size_class structure
is allocated and uses prev_class to check whether the first class
has been allocated.

Signed-off-by: Mahendran Ganesh <opensource.ganesh@...il.com>

---
v1 -> v2:
  - follow Dan Streetman's advise to use prev_class to
    check whether the first class has been allocated
  - follow Minchan Kim's advise to remove uninitialized_var()
---
 mm/zsmalloc.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index b3b57ef..810eda1 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -970,7 +970,7 @@ struct zs_pool *zs_create_pool(gfp_t flags)
 		int size;
 		int pages_per_zspage;
 		struct size_class *class;
-		struct size_class *prev_class;
+		struct size_class *prev_class = NULL;
 
 		size = ZS_MIN_ALLOC_SIZE + i * ZS_SIZE_CLASS_DELTA;
 		if (size > ZS_MAX_ALLOC_SIZE)
@@ -986,8 +986,7 @@ struct zs_pool *zs_create_pool(gfp_t flags)
 		 * characteristics. So, we makes size_class point to
 		 * previous size_class if possible.
 		 */
-		if (i < ZS_SIZE_CLASSES - 1) {
-			prev_class = pool->size_class[i + 1];
+		if (prev_class) {
 			if (can_merge(prev_class, size, pages_per_zspage)) {
 				pool->size_class[i] = prev_class;
 				continue;
@@ -1003,6 +1002,8 @@ struct zs_pool *zs_create_pool(gfp_t flags)
 		class->pages_per_zspage = pages_per_zspage;
 		spin_lock_init(&class->lock);
 		pool->size_class[i] = class;
+
+		prev_class = class;
 	}
 
 	pool->flags = flags;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/