linux-kernel - Re: [PATCH v2] mm/zsmalloc: avoid duplicate assignment of prev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141124074930.GA22312@bbox>
Date:	Mon, 24 Nov 2014 16:49:30 +0900
From:	Minchan Kim <minchan@...nel.org>
To:	Mahendran Ganesh <opensource.ganesh@...il.com>
Cc:	ngupta@...are.org, iamjoonsoo.kim@....com, ddstreet@...e.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/zsmalloc: avoid duplicate assignment of prev_class

On Fri, Nov 21, 2014 at 09:43:23PM +0800, Mahendran Ganesh wrote:
> In zs_create_pool(), prev_class is assigned (ZS_SIZE_CLASSES - 1)
> times. And the prev_class only references to the previous size_class.
> So we do not need unnecessary assignement.
> 
> This patch assigns *prev_class* when a new size_class structure
> is allocated and uses prev_class to check whether the first class
> has been allocated.
> 
> Signed-off-by: Mahendran Ganesh <opensource.ganesh@...il.com>
Acked-by: Minchan Kim <minchan@...nel.org>

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/