linux-kernel - Re: kdbus: add node and filesystem implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <546F606D.40407@oracle.com>
Date:	Fri, 21 Nov 2014 10:55:25 -0500
From:	Sasha Levin <sasha.levin@...cle.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, arnd@...db.de,
	ebiederm@...ssion.com, gnomes@...rguk.ukuu.org.uk, teg@...m.no,
	jkosina@...e.cz, luto@...capital.net, linux-api@...r.kernel.org,
	linux-kernel@...r.kernel.org
CC:	daniel@...que.org, dh.herrmann@...il.com, tixxdz@...ndz.org
Subject: Re: kdbus: add node and filesystem implementation

On 11/21/2014 12:02 AM, Greg Kroah-Hartman wrote:
> +static struct dentry *fs_dir_iop_lookup(struct inode *dir,
> +					struct dentry *dentry,
> +					unsigned int flags)
> +{
> +	struct dentry *dnew = NULL;
> +	struct kdbus_node *parent;
> +	struct kdbus_node *node;
> +	struct inode *inode;
> +
> +	parent = kdbus_node_from_dentry(dentry->d_parent);
> +	if (!kdbus_node_acquire(parent))
> +		return NULL;
> +
> +	/* returns reference to _acquired_ child node */
> +	node = kdbus_node_find_child(parent, dentry->d_name.name);
> +	if (node) {
> +		dentry->d_fsdata = node;
> +		inode = fs_inode_get(dir->i_sb, node);
> +		if (IS_ERR(inode))
> +			dnew = ERR_CAST(inode);
> +		else
> +			dnew = d_materialise_unique(dentry, inode);

d_materialise_unique() is gone in Al's fs tree:

[mandatory]
        d_materialise_unique() is gone; d_splice_alias() does everything you
        need now.  Remember that they have opposite orders of arguments ;-/

Maybe it's worth basing your git tree on top of Al's rather than a random
-rc, since it's now a filesystem?


Thanks,
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/