linux-kernel - Re: kdbus: add node and filesystem implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Nov 2014 17:13:26 +0100
From:	David Herrmann <dh.herrmann@...il.com>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arnd Bergmann <arnd@...db.de>, ebiederm@...ssion.com,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	Tom Gundersen <teg@...m.no>, Jiri Kosina <jkosina@...e.cz>,
	Andy Lutomirski <luto@...capital.net>,
	Linux API <linux-api@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Daniel Mack <daniel@...que.org>,
	Djalal Harouni <tixxdz@...ndz.org>
Subject: Re: kdbus: add node and filesystem implementation

Hi

On Fri, Nov 21, 2014 at 4:55 PM, Sasha Levin <sasha.levin@...cle.com> wrote:
> On 11/21/2014 12:02 AM, Greg Kroah-Hartman wrote:
>> +static struct dentry *fs_dir_iop_lookup(struct inode *dir,
>> +                                     struct dentry *dentry,
>> +                                     unsigned int flags)
>> +{
>> +     struct dentry *dnew = NULL;
>> +     struct kdbus_node *parent;
>> +     struct kdbus_node *node;
>> +     struct inode *inode;
>> +
>> +     parent = kdbus_node_from_dentry(dentry->d_parent);
>> +     if (!kdbus_node_acquire(parent))
>> +             return NULL;
>> +
>> +     /* returns reference to _acquired_ child node */
>> +     node = kdbus_node_find_child(parent, dentry->d_name.name);
>> +     if (node) {
>> +             dentry->d_fsdata = node;
>> +             inode = fs_inode_get(dir->i_sb, node);
>> +             if (IS_ERR(inode))
>> +                     dnew = ERR_CAST(inode);
>> +             else
>> +                     dnew = d_materialise_unique(dentry, inode);
>
> d_materialise_unique() is gone in Al's fs tree:
>
> [mandatory]
>         d_materialise_unique() is gone; d_splice_alias() does everything you
>         need now.  Remember that they have opposite orders of arguments ;-/

That was actually pushed after we prepared v2, so I haven't seen it
yet. I now rebased on top of vfs.git#for-next, with
d_materialise_unique() -> d_splice_alias(). Thanks for the hint!

> Maybe it's worth basing your git tree on top of Al's rather than a random
> -rc, since it's now a filesystem?

Sure, sounds good.

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/