linux-kernel - Re: arm: pxa: CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Nov 2014 17:48:55 +0100
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Valentin Rothberg <valentinrothberg@...il.com>,
	"Yann E. MORIN" <yann.morin.1998@...e.fr>,
	Michal Marek <mmarek@...e.cz>, Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Russell King <linux@....linux.org.uk>,
	linux-kbuild@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: arm: pxa: CPU_PXA27x?

Paul Bolle <pebolle@...cali.nl> writes:

> Robert,
>
> Your commit 03ec7fe70c5c ("arm: pxa: add pxa27x device-tree support") is
> included in today's linux-next (ie, next-20141121). It adds a select
> statement for CPU_PXA27x. But there's no Kconfig symbol CPU_PXA27x.
Ah yes, you're perfectly right, CPU_PXA27x was not the one, it was PXA27x, sic
..

>
> Why is that select needed? For what it's worth: __cpu_is_pxa27x()
> compiles to something interesting if CONFIG_PXA27x is defined.
You mean "is not defined", right ?

That (CONFIG_PXA27x) select is needed because without it the arm cpu
architecture is not selected, ie. CONFIG_CPU_XSCALE is not set. And this in turn
is needed to choose the basic arm operations like TLB handling, cache handling,
etc ... You cannot compile a single platform kernel without this.

As a poor excuse, I hadn't seen this because this resulted from a poor merge
resolution which brought in both "select PXA27x" and "select CPU_PXA27x".

> In https://lkml.org/lkml/2014/9/30/578 I proposed a patch that emits a
> warning in cases like this. Like _all_ Kconfig related patches I've seen
> flying by lately it appears to be dropped in /dev/null. What's going on?
For that one I don't know.

Ah, and yes I'll send an update patch to remove the "select CPU_PXA27x", thanks
for noticing this.

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/