linux-kernel - Re: crypto: user - crypto_alg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141125090601.GA6244@gondor.apana.org.au>
Date:	Tue, 25 Nov 2014 17:06:01 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Steffen Klassert <steffen.klassert@...unet.com>
Cc:	Stephan Mueller <smueller@...onox.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: crypto: user - crypto_alg_match removal

On Tue, Nov 25, 2014 at 09:42:25AM +0100, Steffen Klassert wrote:
>
> Well, I think there is a small but important difference. If a user
> requests a driver name that would match an algorithm name (i.e. cbc(aes)
> instead of cbc(aes-asm)) crypto_alg_lookup() returns the algorithm with
> the highest priority instead of telling that we don't have a driver with
> the name cbc(aes).

Does this matter though? The current user interface is only used to
query specific driver names which should never be equal to an
algorithm name.  So doing so already invokes undefined behaviour.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/