linux-kernel - Re: [PATCH v3] ASoC: Remove 'const' from the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Nov 2014 14:36:15 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Mark Brown <broonie@...nel.org>,
	Jean-Francois Moine <moinejf@...e.fr>
CC:	Liam Girdwood <lgirdwood@...il.com>,
	Russell King <linux@....linux.org.uk>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ASoC: Remove 'const' from the device_node pointers

On 11/25/2014 02:13 PM, Mark Brown wrote:
> On Tue, Nov 25, 2014 at 12:14:48PM +0100, Jean-Francois Moine wrote:
>> As Russell King's explained it, there should not be pointers to
>> struct device_node:
>>
>> "struct device_node is a ref-counted structure.  That means if you
>>   store a reference to it, you should "get" it, and you should "put"
>>   it once you've done.  The act of "put"ing the pointed-to structure
>>   involves writing to that structure, so it is totally unappropriate
>>   to store a device_node structure as a const pointer.  It forces you
>>   to have to cast it back to a non-const pointer at various points
>>   in time to use various OF function calls."
>
> So, we're not holding references here (we're just doing comparisons, the
> references need to be owned before we get into the core)

The core itself will only do the comparisons and it is the board drivers 
responsibility to get and put the references. Making the pointers non const 
allows the board driver to use them to put the reference once the card has 
been unregistered rather than having to keep a separate set of pointers 
around. This should probably be mentioned in the commit message though.

> I'm not seeing anything here removing casts?

This patch used to be part of a two part series where the second patch 
removed the casts. This patch as already been applied though.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/