linux-kernel - Re: [PATCH] ARM: EXYNOS: use u8 for val[] in struct exynos_pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Nov 2014 13:22:53 +0530
From:	Pankaj Dubey <pankaj.dubey@...sung.com>
To:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Kukjin Kim <kgene.kim@...sung.com>
Cc:	Kyungmin Park <kyungmin.park@...sung.com>,
	linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: EXYNOS: use u8 for val[] in struct exynos_pmu_conf

Hi Bartilomiej,


On Tuesday 08 July 2014 05:33 PM, Bartlomiej Zolnierkiewicz wrote:
> Values stored in val[] are never bigger than a byte.
>
>     text    data     bss     dec     hex filename
>     5264       4       4    5272    1498 arch/arm/mach-exynos/pmu.o.before
>     2992       4       4    3000     bb8 arch/arm/mach-exynos/pmu.o.after
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> Acked-by: Kyungmin Park <kyungmin.park@...sung.com>

I tested this patch and it's really helpful to reduce size.
How about resubmitting this change? As this will not get applied on 
current tree.

Thanks,
Pankaj Dubey

> ---
>   arch/arm/mach-exynos/common.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
> index b850db4..55ff019 100644
> --- a/arch/arm/mach-exynos/common.h
> +++ b/arch/arm/mach-exynos/common.h
> @@ -101,7 +101,7 @@ enum sys_powerdown {
>
>   struct exynos_pmu_conf {
>   	void __iomem *reg;
> -	unsigned int val[NUM_SYS_POWERDOWN];
> +	u8 val[NUM_SYS_POWERDOWN];
>   };
>
>   extern void exynos_sys_powerdown_conf(enum sys_powerdown mode);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/