linux-kernel - Re: [alsa-devel][PATCH] ASoC: wm8960: LRCM operation should after software reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5475BA76.8080809@metafoo.de>
Date:	Wed, 26 Nov 2014 12:33:10 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Zidan Wang <b50113@...escale.com>, broonie@...nel.org
CC:	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.de,
	ckeepax@...nsource.wolfsonmicro.com, Li.Xiubo@...escale.com,
	patches@...nsource.wolfsonmicro.com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel][PATCH] ASoC: wm8960: LRCM operation should after
 software reset

On 11/26/2014 12:02 PM, Zidan Wang wrote:
> When shared_lrclk is set, LRCM will be enabled. But the following software
> reset in wm8960_probe will reset it to the default state. So LRCM operation
> should after software reset.

It's probably a better idea to move the reset (together with the other 
register updates) to the I2C driver probe.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/