linux-kernel - Re: [alsa-devel][PATCH] ASoC: wm8960: LRCM operation should after software reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141126163601.GH7712@sirena.org.uk>
Date:	Wed, 26 Nov 2014 16:36:01 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Zidan Wang <b50113@...escale.com>, lgirdwood@...il.com,
	perex@...ex.cz, tiwai@...e.de, ckeepax@...nsource.wolfsonmicro.com,
	Li.Xiubo@...escale.com, patches@...nsource.wolfsonmicro.com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel][PATCH] ASoC: wm8960: LRCM operation should after
 software reset

On Wed, Nov 26, 2014 at 12:33:10PM +0100, Lars-Peter Clausen wrote:
> On 11/26/2014 12:02 PM, Zidan Wang wrote:
> >When shared_lrclk is set, LRCM will be enabled. But the following software
> >reset in wm8960_probe will reset it to the default state. So LRCM operation
> >should after software reset.

> It's probably a better idea to move the reset (together with the other
> register updates) to the I2C driver probe.

Yes, this is not a good fix.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)