linux-kernel - Re: perf/x86/intel/uncore: Add Haswell-EP uncore support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141126141422.GM10824@tassilo.jf.intel.com>
Date:	Wed, 26 Nov 2014 06:14:22 -0800
From:	Andi Kleen <ak@...ux.intel.com>
To:	Dave Jones <davej@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	zheng.z.yan@...el.com, peterz@...radead.org, eranian@...gle.com
Subject: Re: perf/x86/intel/uncore: Add Haswell-EP uncore support

> I couldn't quickly decipher which MSRs we're writing to here in the SDM,
> but are these really 64-bit wide registers that need 32 bits always set to zero ?

Yes the filter MSRs are only 32bit.

> I'm wondering if these should be just wrmsr's instead of wrmsrl's.

Can we just shut up coverity please?

wrmsr() is stupid and error prone and should have never been added as an
interface.

-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/