linux-kernel - Re: Another Obsolete Fix me in trace.h?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141126091543.52dc5bfe@gandalf.local.home>
Date:	Wed, 26 Nov 2014 09:15:43 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Radim Krčmář <rkrcmar@...hat.com>
Cc:	Jan Kiszka <jan.kiszka@...mens.com>,
	Paolo Bonzini <pbonzini@...hat.com>,
	nick <xerofoify@...il.com>, gleb@...nel.org, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, x86@...nel.org,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Another Obsolete Fix me in trace.h?

On Wed, 26 Nov 2014 13:40:26 +0100
Radim Krčmář <rkrcmar@...hat.com> wrote:

> 2014-11-24 22:49+0100, Radim Krčmář:
> > 2014-11-24 16:19-0500, Steven Rostedt:
> > > That wouldn't be too hard to implement.
> > 
> > I'll look at the patch tommorrow.
> 
> The kernel part is trivial.
> Most of the code is going to be in tools/lib/traceevent/event-parse.c.
> 
> I wasn't sure whether to
> 1) define new 'enum print_arg_type' for our function and do exactly what
>    other __print* did
> 2) extend existing PRINT_FUNC with variable arguments and register it as
>    a "global" event handler
> 
> as (2) makes more sense to me, but we already had it when some __print*
> was implemented ... (and I didn't want to dig too deep into the project)

Add a new hardcoded instance. The PRINT_FUNC is for plugins that have a
unique function for the events they handle. Notice that event-parse
does not define any func handlers. If this is to be generic, then lets
make it specified as a new enum.

Thanks,

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/