linux-kernel - Re: [PATCH] perf tools: Do not fail on processing out of order event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141126154459.GD3808@redhat.com>
Date:	Wed, 26 Nov 2014 13:44:59 -0200
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Jiri Olsa <jolsa@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <ak@...ux.intel.com>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Matt Fleming <matt.fleming@...el.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf tools: Do not fail on processing out of order event

Em Wed, Nov 26, 2014 at 04:39:31PM +0100, Jiri Olsa escreveu:
> Linus reported perf report command being interrupted due to
> processing of 'out of order' event, with following error:
> 
>   Timestamp below last timeslice flush
>   0x5733a8 [0x28]: failed to process type: 3
> 
> I could reproduce the issue and in my case it was caused by one
> CPU (mmap) being behind during record and userspace mmap reader
> seeing the data after other CPUs data were already stored.
> 
> It'd be nice to find the source of this hiccup, meanwhile I'm
> submitting change that does not kill the processing, but only
> tracks the number of out of order events and warn user.

Works, for me, thanks for the fast response!

- Arnaldo
 
> Reported-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com>
> Cc: David Ahern <dsahern@...il.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Matt Fleming <matt.fleming@...el.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Stephane Eranian <eranian@...gle.com>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  tools/perf/util/event.h   |  1 +
>  tools/perf/util/session.c | 13 +++++++------
>  2 files changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
> index 09b9e8d3fcf7..c4ffe2bd0738 100644
> --- a/tools/perf/util/event.h
> +++ b/tools/perf/util/event.h
> @@ -242,6 +242,7 @@ struct events_stats {
>  	u32 nr_invalid_chains;
>  	u32 nr_unknown_id;
>  	u32 nr_unprocessable_samples;
> +	u32 nr_unordered_events;
>  };
>  
>  struct attr_event {
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 6ac62ae6b8fa..17a85f527bfc 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -533,15 +533,11 @@ int perf_session_queue_event(struct perf_session *s, union perf_event *event,
>  		return -ETIME;
>  
>  	if (timestamp < oe->last_flush) {
> -		WARN_ONCE(1, "Timestamp below last timeslice flush\n");
> -
> -		pr_oe_time(timestamp,      "out of order event");
> +		pr_oe_time(timestamp,      "out of order event\n");
>  		pr_oe_time(oe->last_flush, "last flush, last_flush_type %d\n",
>  			   oe->last_flush_type);
>  
> -		/* We could get out of order messages after forced flush. */
> -		if (oe->last_flush_type != OE_FLUSH__HALF)
> -			return -EINVAL;
> +		s->stats.nr_unordered_events++;
>  	}
>  
>  	new = ordered_events__new(oe, timestamp, event);
> @@ -1118,6 +1114,11 @@ static void perf_session__warn_about_errors(const struct perf_session *session,
>  			    "Do you have a KVM guest running and not using 'perf kvm'?\n",
>  			    session->stats.nr_unprocessable_samples);
>  	}
> +
> +	if (session->stats.nr_unordered_events != 0) {
> +		ui__warning("%u out of order events recorded.\n",
> +			    session->stats.nr_unordered_events);
> +	}
>  }
>  
>  volatile int session_done;
> -- 
> 1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/