lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Nov 2014 18:46:35 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Steven Rostedt <rostedt@...dmis.org> Cc: Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [patch] tracing: off by one in __trace_array_vprintk() On Wed, Nov 26, 2014 at 10:22:44AM -0500, Steven Rostedt wrote: > On Wed, 26 Nov 2014 18:05:41 +0300 > Dan Carpenter <dan.carpenter@...cle.com> wrote: > > > On Wed, Nov 26, 2014 at 09:43:06AM -0500, Steven Rostedt wrote: > > > I highly doubt it's much of a speed up. And we do that by sacrificing > > > that one byte of buffer, which would lose the printk if len does equal > > > TRACE_BUF_SIZE. > > > > > > I don't see a bug here. What exactly are you trying to fix? > > > > Heh. vsnprintf() is going to put a NUL char at the end of the string > > even if you don't plan to use it. :P > > > > Another option would be to just print truncated output. We could use > > vscnprintf() and remove the off by one limit check. > > Yes, that is a better patch. The previous one wasn't really fixing > anything. But printing truncated output is better than nothing. > > Want to send it officially? > Will do. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists