linux-kernel - [PATCH 3.18 v2] kernel: avoid possible overflow in range's cmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-id: <4F37A778-A4C7-4DC6-AA17-8E44E6914A36@me.com>
Date:	Tue, 25 Nov 2014 17:09:03 -0700
From:	Louis Langholtz <lou_langholtz@...com>
To:	linux-kernel@...r.kernel.org
Cc:	yinghai@...nel.org
Subject: [PATCH 3.18 v2] kernel: avoid possible overflow in range's cmp_range()

Avoid overflow possibility.

Signed-off-by: Louis Langholtz <lou_langholtz@...com>
---
diff --git a/kernel/range.c b/kernel/range.c
index 322ea8e..06d9ee7 100644
--- a/kernel/range.c
+++ b/kernel/range.c
@@ -113,12 +113,16 @@ static int cmp_range(const void *x1, const void *x2)
 {
        const struct range *r1 = x1;
        const struct range *r2 = x2;
-       s64 start1, start2;
+       u64 start1, start2;
 
        start1 = r1->start;
        start2 = r2->start;
 
-       return start1 - start2;
+       if (start1 < start2)
+               return -1;
+       if (start1 > start2)
+               return 1;
+       return 0;
 }
 
 int clean_sort_range(struct range *range, int az)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/