| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141128085436.GF4911@mwanda> Date: Fri, 28 Nov 2014 11:54:37 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: 敬锐 <micky_ching@...lsil.com.cn> Cc: "sameo@...ux.intel.com" <sameo@...ux.intel.com>, "lee.jones@...aro.org" <lee.jones@...aro.org>, "chris@...ntf.net" <chris@...ntf.net>, "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 王炜 <wei_wang@...lsil.com.cn>, "rogerable@...ltek.com" <rogerable@...ltek.com>, "devel@...uxdriverproject.org" <devel@...uxdriverproject.org> Subject: Re: [PATCH 1/2] mfd: rtsx: add func to split u32 into register On Fri, Nov 28, 2014 at 02:10:36AM +0000, 敬锐 wrote: > eg, in sd_ops.c the cmd.arg is constructed bit by bit, we can put the right > byte to the right register by shift, so the endian check is not need. I looked at drivers/mmc/core/sd_ops.c and cmd.arg seems to be cpu endian. The new function assumes that the cpu is little endian and manually converts it to little endian. This is an endian bug. I think my fix is correct or something similar. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists