lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Nov 2014 18:40:31 +0100 From: Beniamino Galvani <b.galvani@...il.com> To: Yingjoe Chen <yingjoe.chen@...iatek.com> Cc: Mark Rutland <mark.rutland@....com>, Jason Cooper <jason@...edaemon.net>, Thomas Gleixner <tglx@...utronix.de>, Jiang Liu <jiang.liu@...ux.intel.com>, Marc Zyngier <marc.zyngier@....com>, Boris BREZILLON <boris.brezillon@...e-electrons.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Russell King <linux@....linux.org.uk>, Pawel Moll <pawel.moll@....com>, srv_heupstream@...iatek.com, devicetree@...r.kernel.org, hc.yen@...iatek.com, yh.chen@...iatek.com, linux-kernel@...r.kernel.org, Yijing Wang <wangyijing@...wei.com>, Rob Herring <robh+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, nathan.chung@...iatek.com, Sascha Hauer <kernel@...gutronix.de>, Grant Likely <grant.likely@...aro.org>, eddie.huang@...iatek.com, yingjoe.chen@...il.com, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v8 2/4] ARM: mediatek: Add sysirq interrupt polarity support On Tue, Nov 25, 2014 at 04:04:20PM +0800, Yingjoe Chen wrote: > Mediatek SoCs have interrupt polarity support in sysirq which > allows to invert polarity for given interrupt. Add this support > using hierarchy irq domain. > > [...] > > +static int __init mtk_sysirq_of_init(struct device_node *node, > + struct device_node *parent) > +{ > + struct irq_domain *domain, *domain_parent; > + struct mtk_sysirq_chip_data *chip_data; > + int ret = 0; > + > + domain_parent = irq_find_host(parent); > + if (!domain_parent) { > + pr_err("mtk_sysirq: interrupt-parent not found\n"); > + return -EINVAL; > + } > + > + chip_data = kzalloc(sizeof(*chip_data), GFP_KERNEL); > + if (!chip_data) > + return -ENOMEM; > + > + chip_data->intpol_base = of_io_request_and_map(node, 0, "intpol"); > + if (!chip_data->intpol_base) { Hi, you should use IS_ERR() to check the return value here. Beniamino -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists