linux-kernel - Re: [PATCH v8 2/4] ARM: mediatek: Add sysirq interrupt polarity support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1417442973.24330.6.camel@mtksdaap41>
Date:	Mon, 1 Dec 2014 22:09:33 +0800
From:	Yingjoe Chen <yingjoe.chen@...iatek.com>
To:	Beniamino Galvani <b.galvani@...il.com>
CC:	Mark Rutland <mark.rutland@....com>,
	Jason Cooper <jason@...edaemon.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Marc Zyngier <marc.zyngier@....com>,
	Boris BREZILLON <boris.brezillon@...e-electrons.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Russell King <linux@....linux.org.uk>,
	Pawel Moll <pawel.moll@....com>, <srv_heupstream@...iatek.com>,
	<devicetree@...r.kernel.org>, <hc.yen@...iatek.com>,
	<yh.chen@...iatek.com>, <linux-kernel@...r.kernel.org>,
	Yijing Wang <wangyijing@...wei.com>,
	Rob Herring <robh+dt@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	<nathan.chung@...iatek.com>, Sascha Hauer <kernel@...gutronix.de>,
	Grant Likely <grant.likely@...aro.org>,
	<eddie.huang@...iatek.com>, <yingjoe.chen@...il.com>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v8 2/4] ARM: mediatek: Add sysirq interrupt polarity
 support

On Sat, 2014-11-29 at 18:40 +0100, Beniamino Galvani wrote:
> On Tue, Nov 25, 2014 at 04:04:20PM +0800, Yingjoe Chen wrote:
> > Mediatek SoCs have interrupt polarity support in sysirq which
> > allows to invert polarity for given interrupt. Add this support
> > using hierarchy irq domain.
> >
> > [...]
> > 
> > +static int __init mtk_sysirq_of_init(struct device_node *node,
> > +				     struct device_node *parent)
> > +{
> > +	struct irq_domain *domain, *domain_parent;
> > +	struct mtk_sysirq_chip_data *chip_data;
> > +	int ret = 0;
> > +
> > +	domain_parent = irq_find_host(parent);
> > +	if (!domain_parent) {
> > +		pr_err("mtk_sysirq: interrupt-parent not found\n");
> > +		return -EINVAL;
> > +	}
> > +
> > +	chip_data = kzalloc(sizeof(*chip_data), GFP_KERNEL);
> > +	if (!chip_data)
> > +		return -ENOMEM;
> > +
> > +	chip_data->intpol_base = of_io_request_and_map(node, 0, "intpol");
> > +	if (!chip_data->intpol_base) {
> 
> Hi,
> 
> you should use IS_ERR() to check the return value here.

Thanks for catching this. I think this is merged, so I'll prepare a new
patch to fix this.

Joe.C


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/