linux-kernel - Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141129095632.69361457@wiggum>
Date:	Sat, 29 Nov 2014 09:56:32 +0100
From:	Michael Büsch <m@...s.ch>
To:	nick <xerofoify@...il.com>
Cc:	Rafał Miłecki <zajec5@...il.com>,
	Stefano Brivio <stefano.brivio@...imi.it>,
	Network Development <netdev@...r.kernel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	b43-dev <b43-dev@...ts.infradead.org>
Subject: Re: [PATCH] drivers:net:wireless: Add mutex locking for function,
 b43_op_beacon_set_time in main.c

On Fri, 28 Nov 2014 22:32:30 -0500
nick <xerofoify@...il.com> wrote:

> I don't have hardware for this driver on me, so I didn't test it. However this seems to 
> be correct from my reading of the code around this function and other locking related
> to this driver.

From the current docs:

>  * @set_tim: Set TIM bit. mac80211 calls this function when a TIM bit
>  *      must be set or cleared for a given STA. Must be atomic.

So it is not allowed to lock a mutex here.

-- 
Michael

Content of type "application/pgp-signature" skipped