lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Nov 2014 10:04:02 +0100 From: Rafał Miłecki <zajec5@...il.com> To: Michael Büsch <m@...s.ch> Cc: nick <xerofoify@...il.com>, Stefano Brivio <stefano.brivio@...imi.it>, Network Development <netdev@...r.kernel.org>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, b43-dev <b43-dev@...ts.infradead.org> Subject: Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c On 29 November 2014 at 09:56, Michael Büsch <m@...s.ch> wrote: > On Fri, 28 Nov 2014 22:32:30 -0500 > nick <xerofoify@...il.com> wrote: > >> I don't have hardware for this driver on me, so I didn't test it. However this seems to >> be correct from my reading of the code around this function and other locking related >> to this driver. > > From the current docs: > >> * @set_tim: Set TIM bit. mac80211 calls this function when a TIM bit >> * must be set or cleared for a given STA. Must be atomic. > > So it is not allowed to lock a mutex here. Nicholas please be more careful with your patches. It seems your patch is wrong, you didn't check the docs and you didn't even say in the first place that it wasn't tested. You could at least submit with with RFT tag or sth. -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists