linux-kernel - Re: [PATCH] iscsi-target: fix error path in iscsi_target_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 30 Nov 2014 18:30:51 +0200
From:	Sagi Grimberg <sagig@....mellanox.co.il>
To:	Lino Sanfilippo <LinoSanfilippo@....de>, nab@...ux-iscsi.org
CC:	sagig@...lanox.com, cvubrugier@...oo.fr, joern@...fs.org,
	steven.allen@...estorage.com, arshad.hussain@...softinc.com,
	agrover@...hat.com, linux-scsi@...r.kernel.org,
	target-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iscsi-target: fix error path in iscsi_target_init_module()

On 11/30/2014 1:00 PM, Lino Sanfilippo wrote:
> In iscsi_target_init_module() unwind transport protocol registration in case
> that iscsit_load_discovery_tpg() failed.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@....de>
> ---
>   drivers/target/iscsi/iscsi_target.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index 73e58d2..f8ec322 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -609,6 +609,7 @@ static int __init iscsi_target_init_module(void)
>
>   	return ret;
>   r2t_out:
> +	iscsit_unregister_transport(&iscsi_target_transport);
>   	kmem_cache_destroy(lio_r2t_cache);
>   ooo_out:
>   	kmem_cache_destroy(lio_ooo_cache);
>

Yep, Looks good.

Reviewed-by: Sagi Grimberg <sagig@...lanox.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/