linux-kernel - Re: [PATCH] iscsi-target: fix error path in iscsi_target_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1417500716.11477.1.camel@haakon3.risingtidesystems.com>
Date:	Mon, 01 Dec 2014 22:11:56 -0800
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Lino Sanfilippo <LinoSanfilippo@....de>
Cc:	sagig@...lanox.com, cvubrugier@...oo.fr, joern@...fs.org,
	steven.allen@...estorage.com, arshad.hussain@...softinc.com,
	agrover@...hat.com, linux-scsi@...r.kernel.org,
	target-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iscsi-target: fix error path in
 iscsi_target_init_module()

On Sun, 2014-11-30 at 12:00 +0100, Lino Sanfilippo wrote:
> In iscsi_target_init_module() unwind transport protocol registration in case
> that iscsit_load_discovery_tpg() failed.
> 
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@....de>
> ---
>  drivers/target/iscsi/iscsi_target.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index 73e58d2..f8ec322 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -609,6 +609,7 @@ static int __init iscsi_target_init_module(void)
>  
>  	return ret;
>  r2t_out:
> +	iscsit_unregister_transport(&iscsi_target_transport);
>  	kmem_cache_destroy(lio_r2t_cache);
>  ooo_out:
>  	kmem_cache_destroy(lio_ooo_cache);

Nice catch.  Applied to target-pending/for-next.

Thanks Lino!

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/