| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141201111535.GA15845@x1>
Date: Mon, 1 Dec 2014 11:15:35 +0000
From: Lee Jones <lee.jones@...aro.org>
To: Jacek Anaszewski <j.anaszewski@...sung.com>
Cc: linux-leds@...r.kernel.org, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org, kyungmin.park@...sung.com,
b.zolnierkie@...sung.com, pavel@....cz, cooloney@...il.com,
rpurdie@...ys.net, sakari.ailus@....fi, s.nawrocki@...sung.com,
Andrzej Hajda <a.hajda@...sung.com>,
SangYoung Son <hello.son@...sung.com>,
Samuel Ortiz <sameo@...ux.intel.com>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH/RFC v8 11/14] DT: Add documentation for the mfd Maxim
max77693
On Fri, 28 Nov 2014, Jacek Anaszewski wrote:
> This patch adds device tree binding documentation for
> the flash cell of the Maxim max77693 multifunctional device.
>
> Signed-off-by: Jacek Anaszewski <j.anaszewski@...sung.com>
> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
> Acked-by: Kyungmin Park <kyungmin.park@...sung.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: SangYoung Son <hello.son@...sung.com>
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Cc: Bryan Wu <cooloney@...il.com>
> Cc: Richard Purdie <rpurdie@...ys.net>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Pawel Moll <pawel.moll@....com>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Ian Campbell <ijc+devicetree@...lion.org.uk>
> Cc: Kumar Gala <galak@...eaurora.org>
> Cc: <devicetree@...r.kernel.org>
> ---
> Documentation/devicetree/bindings/mfd/max77693.txt | 74 ++++++++++++++++++++
> 1 file changed, 74 insertions(+)
This definitely requires a DT Ack.
> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
> index 01e9f30..50a8dad 100644
> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
> @@ -41,6 +41,62 @@ Optional properties:
> To get more informations, please refer to documentaion.
> [*] refer Documentation/devicetree/bindings/pwm/pwm.txt
>
> +- led-flash : the LED submodule device node
> +
> +There are two led outputs available - fled1 and fled2. Each of them can
> +control a separate led or they can be connected together to double
> +the maximum current for a single connected led. One led is represented
> +by one child node.
> +
> +Required properties:
> +- compatible : must be "maxim,max77693-flash"
I'm not sure this compatible string is suitable. It looks like
NOR/NAND Flash to me. Perhaps 'fled', or just 'led' would be better.
> +Optional properties:
> +- maxim,fleds : array of current outputs in order: fled1, fled2
Nit: Sentences start with an uppercase character.
This is true for all other occurrences.
> + Note: both current outputs can be connected to a single led
> + Possible values:
> + 0 - the output is left disconnected,
> + 1 - a diode is connected to the output.
> +- maxim,trigger-type : Array of trigger types in order: flash, torch
> + Possible trigger types:
> + 0 - Rising edge of the signal triggers the flash/torch,
> + 1 - Signal level controls duration of the flash/torch.
> +- maxim,trigger : Array of flags indicating which trigger can activate given led
> + in order: fled1, fled2
> + Possible flag values (can be combined):
> + 1 - FLASH pin of the chip,
> + 2 - TORCH pin of the chip,
> + 4 - software via I2C command.
> +- maxim,boost-mode :
> + In boost mode the device can produce up to 1.2A of total current
> + on both outputs. The maximum current on each output is reduced
> + to 625mA then. If there are two child led nodes defined then boost
> + is enabled by default.
> + Possible values:
> + 0 - no boost,
> + 1 - adaptive mode,
> + 2 - fixed mode.
> +- maxim,boost-vout : Output voltage of the boost module in millivolts.
> +- maxim,vsys-min : Low input voltage level in millivolts. Flash is not fired
> + if chip estimates that system voltage could drop below this level due
> + to flash power consumption.
> +
> +A child node must be defined per sub-led.
> +
> +Required properties of the LED child node:
> +- label : see Documentation/devicetree/bindings/leds/common.txt
> +- maxim,fled_id : identifier of the fled output the led is connected to:
> + 1 - FLED1,
> + 2 - FLED2.
Better to define all of these random numbers in include/dt-bindings.
> +Optional properties of the LED child node:
> +- max-microamp : see Documentation/devicetree/bindings/leds/common.txt
> + Range: 15625 - 250000
> +- flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt
> + Range: 15625 - 1000000
> +- flash-timeout-microsec : see Documentation/devicetree/bindings/leds/common.txt
> + Range: 62500 - 1000000
> +
> Example:
> max77693@66 {
> compatible = "maxim,max77693";
> @@ -73,4 +129,22 @@ Example:
> pwms = <&pwm 0 40000 0>;
> pwm-names = "haptic";
> };
> +
> + led_flash: led-flash {
Should both be underscore. I believe the second portion here should
be more generic "led" for instance.
> + compatible = "maxim,max77693-flash";
> + maxim,fleds = <1 0>;
> + maxim,trigger = <7 0>;
> + maxim,trigger-type = <0 1>;
> + maxim,boost-mode = <0>;
> + maxim,boost-vout = <5000>;
> + maxim,vsys-min = <2400>;
These will all have to be signed off by a DT maintainer.
> + camera-flash {
> + maxim,fled_id = <1>
> + label = "max77693-flash";
> + max-microamp = <250000>;
> + flash-max-microamp = <1000000>;
> + flash-timeout-microsec = <1000000>;
> + }
Missing ';'
You should probably test your example code.
> + };
> };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists