linux-kernel - Re: [PATCH] Documentation: memory-barriers: Fix typo in the first example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141202161519.581ea1af@lwn.net>
Date:	Tue, 2 Dec 2014 16:15:19 -0500
From:	Jonathan Corbet <corbet@....net>
To:	Srikanth Thokala <sriku.linux@...il.com>
Cc:	linux-doc@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH] Documentation: memory-barriers: Fix typo in the first
 example

On Thu, 27 Nov 2014 12:19:26 +0530
Srikanth Thokala <sriku.linux@...il.com> wrote:

> Hi,
> 
> Kindly review the patch.

To me it looks right.  Something like this, though, needs an ack from
Paul (cc'd) before I can be really confident.  Paul...?

jon

> Thanks
> Srikanth
> 
> On Tue, Nov 18, 2014 at 10:09 AM, Srikanth Thokala
> <sriku.linux@...il.com> wrote:
> > In the first example, the loads into 'x' and 'y' on CPU 2 doesn't
> > match the sequence of events described below it.  To match the
> > sequence of events, the values of 'A' and 'B' should be loaded
> > into 'x' and 'y' respectively.
> >
> > Signed-off-by: Srikanth Thokala <sriku.linux@...il.com>
> > ---
> >  Documentation/memory-barriers.txt | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
> > index 22a969c..2770bce 100644
> > --- a/Documentation/memory-barriers.txt
> > +++ b/Documentation/memory-barriers.txt
> > @@ -115,8 +115,8 @@ For example, consider the following sequence of events:
> >         CPU 1           CPU 2
> >         =============== ===============
> >         { A == 1; B == 2 }
> > -       A = 3;          x = B;
> > -       B = 4;          y = A;
> > +       A = 3;          x = A;
> > +       B = 4;          y = B;
> >
> >  The set of accesses as seen by the memory system in the middle can be arranged
> >  in 24 different combinations:
> > --
> > 1.9.1
> >
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/