linux-kernel - Re: [PATCH] Staging: line6: fix parentheses around macro in usbdefs.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1417632358.2902.20.camel@perches.com>
Date:	Wed, 03 Dec 2014 10:45:58 -0800
From:	Joe Perches <joe@...ches.com>
To:	Sam van Kampen <sam@...svk.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Chris Bajumpaa <cbajumpa@...il.com>,
	Monam Agarwal <monamagarwal123@...il.com>,
	Davide Berardi <berardi.dav@...il.com>,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] Staging: line6: fix parentheses around macro in
 usbdefs.h

On Wed, 2014-12-03 at 19:34 +0100, Sam van Kampen wrote:
> This patch fixes the error "Macros with complex values should be enclosed in
> parentheses", as reported by checkpatch.pl.
[]
> diff --git a/drivers/staging/line6/usbdefs.h b/drivers/staging/line6/usbdefs.h
[]
> @@ -40,7 +40,7 @@
>  #define LINE6_DEVID_TONEPORT_UX2  0x4142
>  #define LINE6_DEVID_VARIAX        0x534d
>  
> -#define LINE6_BIT(x) LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x
> +#define LINE6_BIT(x) (LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x)

The uses are pretty ugly.

It'd probably be nicer if all the LINE6_BIT uses were
direct enum declarations instead.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/