linux-kernel - Re: [PATCH] Staging: line6: fix parentheses around macro in usbdefs.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150112195111.GA10572@kroah.com>
Date:	Mon, 12 Jan 2015 11:51:12 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Sam van Kampen <sam@...svk.net>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Chris Bajumpaa <cbajumpa@...il.com>,
	Monam Agarwal <monamagarwal123@...il.com>,
	Davide Berardi <berardi.dav@...il.com>,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] Staging: line6: fix parentheses around macro in usbdefs.h

On Wed, Dec 03, 2014 at 07:34:42PM +0100, Sam van Kampen wrote:
> This patch fixes the error "Macros with complex values should be enclosed in
> parentheses", as reported by checkpatch.pl.
> 
> Signed-off-by: Sam van Kampen <sam@...svk.net>
> ---
>  drivers/staging/line6/usbdefs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/line6/usbdefs.h b/drivers/staging/line6/usbdefs.h
> index 2d1cc47..48958b5 100644
> --- a/drivers/staging/line6/usbdefs.h
> +++ b/drivers/staging/line6/usbdefs.h
> @@ -40,7 +40,7 @@
>  #define LINE6_DEVID_TONEPORT_UX2  0x4142
>  #define LINE6_DEVID_VARIAX        0x534d
>  
> -#define LINE6_BIT(x) LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x
> +#define LINE6_BIT(x) (LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x)
>  
>  enum {
>  	LINE6_INDEX_BASSPODXT,

I love this line in the driver, it proves that people make changes to
the code without even building it.

Please ALWAYS test-build your patches, otherwise you waste people's time
and make them grumpy.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/