[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA7nrth+h32Un2C4z106wL181eru7hwFDxMdS00X55h5Zw=-Vg@mail.gmail.com>
Date: Thu, 4 Dec 2014 12:13:46 +0530
From: rajeev kumar <rajeevkumar.linux@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Andrew Jackson <Andrew.Jackson@....com>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Liam Girdwood <lgirdwood@...il.com>,
Liviu Dudau <Liviu.Dudau@....com>
Subject: Re: [PATCH 2/5] ASoC: dwc: Don't allow negative use counts
On Thu, Dec 4, 2014 at 12:10 PM, rajeev kumar
<rajeevkumar.linux@...il.com> wrote:
> On Wed, Dec 3, 2014 at 10:55 PM, Mark Brown <broonie@...nel.org> wrote:
>> On Wed, Dec 03, 2014 at 04:38:55PM +0000, Andrew Jackson wrote:
>>
>>> case SNDRV_PCM_TRIGGER_STOP:
>>> case SNDRV_PCM_TRIGGER_SUSPEND:
>>> case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>>> - dev->active--;
>>> + if (dev->active > 0)
>>> + dev->active--;
>>
>> How is this triggering - this sounds like you're papering over some
>> other bug somewhere?
This check can be removed as it is not going to triggered.
B'rgds
~Rajeev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists