linux-kernel - Re: [PATCH v2 1/3] i2c: cadence: Handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141204183242.GJ7944@katana>
Date:	Thu, 4 Dec 2014 19:32:43 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Harini Katakam <harinik@...inx.com>
Cc:	mark.rutland@....com, michal.simek@...inx.com,
	soren.brinkmann@...inx.com, linux-arm-kernel@...ts.infradead.org,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	vishnum@...inx.com, harinikatakamlinux@...il.com
Subject: Re: [PATCH v2 1/3] i2c: cadence: Handle > 252 byte transfers


> +		/*
> +		 * If the device is sending data If there is further
> +		 * data to be sent. Calculate the available space
> +		 * in FIFO and fill the FIFO with that many bytes.
> +		 */

This comment looks broken. In general, I think there should be more
comments explaining why things have to be done this way.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)