linux-kernel - Re: [PATCH] watchdog: Fixed missing blank line warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFnntG3orLhA5tOHM+k3JMbCo7Atinq_1gaWPBR6CySqw7ytMA@mail.gmail.com>
Date:	Fri, 5 Dec 2014 19:39:12 +0530
From:	Athira Lekshmi C V <andnlnbn18@...il.com>
To:	Jeremiah Mahler <jmmahler@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: Fixed missing blank line warning

Hello

Should I resubmit the above patch again including the version number,
or can I start doing so from the next time onwards ?

Thank You
Athira Lekshmi

On Fri, Dec 5, 2014 at 7:30 PM, Jeremiah Mahler <jmmahler@...il.com> wrote:
> Athira,
>
> On Fri, Dec 05, 2014 at 07:13:54PM +0530, Athira Lekshmi wrote:
>> Fixed the checkpatch warning:
>> Missing a blank line after declarations
>>
>> Signed-off-by: Athira Lekshmi <andnlnbn18@...il.com>
>> ---
>>  drivers/watchdog/mixcomwd.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/watchdog/mixcomwd.c b/drivers/watchdog/mixcomwd.c
>> index be86ea3..03b7612e 100644
>> --- a/drivers/watchdog/mixcomwd.c
>> +++ b/drivers/watchdog/mixcomwd.c
>> @@ -183,6 +183,7 @@ static ssize_t mixcomwd_write(struct file *file, const char __user *data,
>>
>>                       for (i = 0; i != len; i++) {
>>                               char c;
>> +
>>                               if (get_user(c, data + i))
>>                                       return -EFAULT;
>>                               if (c == 'V')
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>
> It is helpful to add a version number when patches are re-submitted to
> avoid them being confused for a new patch.  git-format-patch has the
> --reroll-count option which makes this easy to do.
>
> --
> - Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/