linux-kernel - Re: [PATCH v4 0/5] Add Spreadtrum Sharkl64 Platform support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+H2tpF0pJ1w-MibuOv=HiXJy6pCqUJ2fDUwxLs49y0y4LEd5w@mail.gmail.com>
Date:	Fri, 5 Dec 2014 22:13:32 +0800
From:	Orson Zhai <orsonzhai@...il.com>
To:	Lyra Zhang <zhang.lyra@...il.com>,
	Mark Rutland <mark.rutland@....com>
Cc:	Chunyan Zhang <chunyan.zhang@...eadtrum.com>,
	"arnd@...db.de" <arnd@...db.de>, Will Deacon <Will.Deacon@....com>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"geng.ren@...eadtrum.com" <geng.ren@...eadtrum.com>,
	"zhizhou.zhang@...eadtrum.com" <zhizhou.zhang@...eadtrum.com>,
	"wei.qiao@...eadtrum.com" <wei.qiao@...eadtrum.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"sprdlinux@...elists.org" <sprdlinux@...elists.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, allen.zhang@...eadtrum.com
Subject: Re: [PATCH v4 0/5] Add Spreadtrum Sharkl64 Platform support

Hi, Mark,

On Fri, Dec 5, 2014 at 8:27 PM, Lyra Zhang <zhang.lyra@...il.com> wrote:
> On Fri, Dec 5, 2014 at 6:40 PM, Mark Rutland <mark.rutland@....com> wrote:
>> Hi,
>>
>> On Thu, Dec 04, 2014 at 11:34:15AM +0000, Chunyan Zhang wrote:
>>> Spreadtrum is a rapid growing chip vendor providing smart phone total solutions.
>>>
>>> Sharkl64 Platform is nominated as a SoC infrastructure that supports 4G/3G/2G
>>> standards based on ARMv8 multiple core architecture.Now we have only one
>>> SoC(SC9836) based on this Platform in developing.
>>>
>>> This patchset adds Sharkl64 support in arm64 device tree and the serial driver
>>> of SC9836-UART.
>>>
>>> This patchset also has patches which address "sprd" prefix and DT compatible
>>> strings for nodes which appear un-documented.
>>>
>>> This version code was tesed both on Fast Mode and sc9836-fpga board.
>>> We use the latest boot-wrapper-aarch64 as the bootloader.
>>>
>>> Changes from v3:
>>> * Addressed review comments:
>>>       - Added the description of clock property for sc9836-uart
>>>       - Revised the size of GICC to be 8KiB
>>>       - Added another compatible string for psci-0.1
>>
>> I had open questions on v3 regarding your PSCI imlpementation. You
>> mentioned that you are using the aarch64 bootwrapper, but your DT
>> describes PSCI 0.2, and the (upstream) bootwrapper does not implement
>> PSCI 0.2. Adding the old PSCI compatible string is _not_ sufficient if
>> you do not have a full PSCI 0.2 implementation.
>>
>> Given that PSCI 0.2 requires more functionality to be implemented, I'd
>> like to know that your implementation is spec-compliant (implementing
>> the mandatory functions, nters the kernel in the correct state, etc),
>> and that it has been tested.
>>
>> Would you be able to look at my comments from the last posting please?

I'd like to show you more technical details of our psci implementation.

Here the dt code is fresh from our engineering repository.
As far as I  know our engineers are testing on psci currently.

04b8b5a5 (zhiqiang.zhang 2014-12-04 15:27:17 +0800   98)        psci {
04b8b5a5 (zhiqiang.zhang 2014-12-04 15:27:17 +0800   99)
 compatible = "arm,psci";
04b8b5a5 (zhiqiang.zhang 2014-12-04 15:27:17 +0800  100)
 method = "smc";
04b8b5a5 (zhiqiang.zhang 2014-12-04 15:27:17 +0800  101)
 cpu_on  = <0xc4000003>;
04b8b5a5 (zhiqiang.zhang 2014-12-04 15:27:17 +0800  102)
 cpu_off = <0x84000002>;
04b8b5a5 (zhiqiang.zhang 2014-12-04 15:27:17 +0800  103)
 cpu_suspend = <0xc4000001>;
04b8b5a5 (zhiqiang.zhang 2014-12-04 15:27:17 +0800  104)        };

Does it reveal the information as you concern?
It's no doubt that we'll implement psci-v0.2 eventually.
Considering that the code might be upstreamed in few weeks later, we
submit a psci-v0.2 dts in advanced.

Thanks,
Orson

>>
>> Thanks,
>> Mark.
>> --
>
> Hi, Mark
>
> Ok, I'll check it again with our related engineers.
>
> Actually, I had read all of your comments carefully before sending
> each version of patches, and I replied you a few days early, I guess
> you may miss it :)
>
> If we just implemented psci-0.1 until now, can we submit this path
> without "compatible = "arm,psci-0.2"", but only with " compatible =
> "arm,psci" ".
>
>
>
> Thanks,
> Chunyan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/