linux-kernel - Re: [PATCH 6/20] TTY: fix misspelling of current function in string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5485746F.9080102@suse.cz>
Date:	Mon, 08 Dec 2014 10:50:39 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Joe Perches <joe@...ches.com>
CC:	Julia Lawall <Julia.Lawall@...6.fr>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	kernel-janitors@...r.kernel.org, linux@...musvillemoes.dk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/20] TTY: fix misspelling of current function in string

On 12/08/2014, 10:18 AM, Joe Perches wrote:
> On Mon, 2014-12-08 at 09:49 +0100, Jiri Slaby wrote:
>> On 12/07/2014, 08:20 PM, Julia Lawall wrote:
>>> Replace the last argument of serial_paranoia_check by the actual function
>>> name.
> []
>>> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> []
>>> @@ -931,7 +931,7 @@ static void rs_send_xchar(struct tty_struct *tty, char ch)
>>>  	struct serial_state *info = tty->driver_data;
>>>          unsigned long flags;
>>>  
>>> -	if (serial_paranoia_check(info, tty->name, "rs_send_char"))
>>> +	if (serial_paranoia_check(info, tty->name, "rs_send_xchar"))
>>
>> I wonder, why not to use __func__ here too?
> 
> Nearly identical functions are used in amiserial and cyclades.

And I would bet more. They are mostly copy&paste drivers.

> Disabled in amiserial, enabled in cyclades.
> 
> It might be better to add it to some file like
> drivers/tty/debug_utils.h

Oh no, these should better die, not being generalized. But since the
drivers have nearly no users, if some at all, nobody wants to touch the
code.

-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/