linux-kernel - Re: [PATCH 7/20] drm/i915: fix misspelling of current function in string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fvcqo2w4.fsf@intel.com>
Date:	Mon, 08 Dec 2014 12:24:27 +0200
From:	Jani Nikula <jani.nikula@...ux.intel.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>,
	Daniel Vetter <daniel.vetter@...el.com>
Cc:	kernel-janitors@...r.kernel.org, linux@...musvillemoes.dk,
	joe@...ches.com, David Airlie <airlied@...ux.ie>,
	intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/20] drm/i915: fix misspelling of current function in string

On Sun, 07 Dec 2014, Julia Lawall <Julia.Lawall@...6.fr> wrote:
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
>
> ---
> The semantic patch is difficult to summarize, but is available in the cover
> letter of this patch series.
>
> The message is sort of ambiguous, but I assume that it is intended to refer
> to the function in which the problem is detected.

Hmm, DRM_DEBUG prints __func__ too.

Jani.

>
>  drivers/gpu/drm/i915/i915_gem.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index d2ba315..fa21d1c 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -4335,7 +4335,7 @@ i915_gem_unpin_ioctl(struct drm_device *dev, void *data,
>  	}
>  
>  	if (obj->pin_filp != file) {
> -		DRM_DEBUG("Not pinned by caller in i915_gem_pin_ioctl(): %d\n",
> +		DRM_DEBUG("Not pinned by caller in %s(): %d\n", __func__,
>  			  args->handle);
>  		ret = -EINVAL;
>  		goto out;
>

-- 
Jani Nikula, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/