linux-kernel - Re: [PATCH 3/8] perf data: Add perf data to CTF conversion support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141209101629.GC2516@krava.brq.redhat.com>
Date:	Tue, 9 Dec 2014 11:16:29 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Jiri Olsa <jolsa@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jeremie Galarneau <jgalar@...icios.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Tom Zanussi <tzanussi@...il.com>
Subject: Re: [PATCH 3/8] perf data: Add perf data to CTF conversion support

On Mon, Dec 08, 2014 at 05:13:23PM +0900, Namhyung Kim wrote:
> On Thu, Dec 4, 2014 at 1:23 AM, Jiri Olsa <jolsa@...nel.org> wrote:
> > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> > index 33864dd316e5..2d3229ec0a23 100644
> > --- a/tools/perf/Makefile.perf
> > +++ b/tools/perf/Makefile.perf
> > @@ -402,6 +402,10 @@ LIB_OBJS += $(OUTPUT)util/tsc.o
> >  LIB_OBJS += $(OUTPUT)util/cloexec.o
> >  LIB_OBJS += $(OUTPUT)util/thread-stack.o
> >
> > +ifneq ($(NO_LIBBABELTRACE),1)
> 
> I think we usually do it with just "ifndef".

ok

SNIP

> > +       }
> > +
> > +       if (type & PERF_SAMPLE_TID) {
> > +               ret = value_set_s32(cw, event, "tid", sample->tid);
> > +               if (ret)
> > +                       return -1;
> > +
> > +               ret = value_set_s32(cw, event, "pid", sample->tid);
> 
> sample->pid ?

yes

> 
> 
> > +               if (ret)
> > +                       return -1;
> > +       }
> > +
> > +       if ((type & PERF_SAMPLE_ID) ||
> > +           (type & PERF_SAMPLE_IDENTIFIER)) {
> > +               ret = value_set_u64(cw, event, "id", sample->id);
> > +               if (ret)
> > +                       return -1;
> > +       }
> > +
> > +       if (type & PERF_SAMPLE_STREAM_ID) {
> > +               ret = value_set_u64(cw, event, "stream_id", sample->id);
> 
> sample->stream_id ?

yes

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/