linux-kernel - Re: [PATCH 6/8] perf data: Switch to multiple cpu stream files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141209101828.GD2516@krava.brq.redhat.com>
Date:	Tue, 9 Dec 2014 11:18:28 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Jiri Olsa <jolsa@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jeremie Galarneau <jgalar@...icios.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Tom Zanussi <tzanussi@...il.com>
Subject: Re: [PATCH 6/8] perf data: Switch to multiple cpu stream files

On Mon, Dec 08, 2014 at 05:17:44PM +0900, Namhyung Kim wrote:
> On Thu, Dec 4, 2014 at 1:24 AM, Jiri Olsa <jolsa@...nel.org> wrote:
> > +static int setup_streams(struct ctf_writer *cw, struct perf_session *session)
> > +{
> > +       struct ctf_stream **stream;
> > +       struct perf_header *ph = &session->header;
> > +       int ncpus;
> > +
> > +       /*
> > +        * Try to get the number of cpus used in the data file,
> > +        * if not present fallback to the MAX_CPUS.
> > +        */
> > +       if (!ph)
> 
> I think this check is meaningless since perf_header struct is embedded
> in perf_session so it shouldn't be NULL when refered from a session..

right, it's actually different in the git, I used:

        if (!ph || !ph->env.nr_cpus_avail)
                ncpus = MAX_CPUS;

I attached slightyl older version in email :-\

anyway, I'll send v2 shortly 

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/