linux-kernel - Re: da9052-regulator fails to probe in linux-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Dec 2014 23:07:25 -0200
From:	Fabio Estevam <festevam@...il.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	anthony.olech.opensource@...semi.com,
	support.opensource@...semi.com,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Olof Johansson <olof@...om.net>,
	Lee Jones <lee.jones@...aro.org>
Subject: Re: da9052-regulator fails to probe in linux-next

On Tue, Dec 9, 2014 at 7:47 PM, Mark Brown <broonie@...nel.org> wrote:

> My point is that I'm not seeing anything complaining about those devices
> or the supplies they offer so nothing there indicates to me that there's
> any kind of problem.

Yes, you are right. Sorry for the confusion here.

>> [    0.052239] CPU identified as i.MX6Q, silicon rev 1.2
>> [    0.072014] vdd1p1: 800 <--> 1375 mV at 1100 mV
>> [    0.073027] vdd3p0: 2800 <--> 3150 mV at 3000 mV
>> [    0.073933] vdd2p5: 2000 <--> 2750 mV at 2400 mV
>> [    0.074888] vddarm: 725 <--> 1450 mV at 1150 mV
>> [    0.075935] vddpu: 725 <--> 1450 mV at 1150 mV
>> [    0.076897] vddsoc: 725 <--> 1450 mV at 1200 mV
>
> Remember that these messages are now at debug level.

I was not aware of this change, thanks for letting me know.

Now I am back to the original da9052 regulator probe issue. If I do:

--- a/drivers/mfd/da9052-core.c
+++ b/drivers/mfd/da9052-core.c
@@ -554,7 +554,7 @@ int da9052_device_init(struct da9052 *da9052, u8 chip_id)
                return ret;
        }

-       ret = mfd_add_devices(da9052->dev, -1, da9052_subdev_info,
+       ret = mfd_add_devices(da9052->dev, 0, da9052_subdev_info,
                              ARRAY_SIZE(da9052_subdev_info), NULL, 0, NULL);

,then the da9052 regulator can probe succesfully:

ls /sys/class/regulator/
regulator.0   regulator.11  regulator.14  regulator.2   regulator.5
regulator.8
regulator.1   regulator.12  regulator.15  regulator.3   regulator.6
regulator.9
regulator.10  regulator.13  regulator.16  regulator.4   regulator.7

,except for this one:

[    0.157574] da9052-regulator da9052-regulator.14: invalid regulator
ID specified
[    0.157713] da9052-regulator: probe of da9052-regulator.14 failed
with error -2

Does anyone know why should I change the index of mfd_add_devices() ?

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/