linux-kernel - Re: [PATCH] leds: leds-gpio: Fix the "default-state" property check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54879E08.7030108@intel.com>
Date:	Wed, 10 Dec 2014 02:12:40 +0100
From:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:	Bryan Wu <cooloney@...il.com>,
	Fabio Estevam <fabio.estevam@...escale.com>
CC:	Grant Likely <grant.likely@...aro.org>,
	Jean-Michel Hautbois <jean-michel.hautbois@...alys.com>,
	Fabio Estevam <festevam@...il.com>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds: leds-gpio: Fix the "default-state" property check

On 12/9/2014 8:13 PM, Bryan Wu wrote:
> On Tue, Dec 9, 2014 at 8:31 AM, Fabio Estevam
> <fabio.estevam@...escale.com> wrote:
>> Commit a43f2cbbb009f9 ("leds: leds-gpio: Make use of device property API")
>> caused a regression by reading the incorrect string for the "default-state"
>> property.
>>
>> Fix the property string check to restore the original behaviour.
>>
>> Fixes: a43f2cbbb009 (leds: leds-gpio: Make use of device property API)
> Thanks, please take my Ack
> Acked-by: Bryan Wu <cooloney@...il.com>
>
> I think Rafael will take this fix with other patches through his tree.

Yes, I will, thanks!

And sorry for the breakage ...

>
>> Reported-by: Jean-Michel Hautbois <jean-michel.hautbois@...alys.com>
>> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
>> ---
>>   drivers/leds/leds-gpio.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
>> index 8a8ba11..7ea1ea42 100644
>> --- a/drivers/leds/leds-gpio.c
>> +++ b/drivers/leds/leds-gpio.c
>> @@ -203,7 +203,7 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev)
>>                  fwnode_property_read_string(child, "linux,default-trigger",
>>                                              &led.default_trigger);
>>
>> -               if (!fwnode_property_read_string(child, "linux,default_state",
>> +               if (!fwnode_property_read_string(child, "default-state",
>>                                                   &state)) {
>>                          if (!strcmp(state, "keep"))
>>                                  led.default_state = LEDS_GPIO_DEFSTATE_KEEP;
>> --
>> 1.9.1
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/