linux-kernel - Re: [PATCH 1/2] perf/x86/intel/uncore: Make sure only uncore events are collected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141210235116.GL10824@tassilo.jf.intel.com>
Date:	Wed, 10 Dec 2014 15:51:16 -0800
From:	Andi Kleen <ak@...ux.intel.com>
To:	Jiri Olsa <jolsa@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	Vince Weaver <vince@...ter.net>,
	"Yan, Zheng" <zheng.z.yan@...el.com>, Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH 1/2] perf/x86/intel/uncore: Make sure only uncore events
 are collected

On Wed, Dec 10, 2014 at 09:23:50PM +0100, Jiri Olsa wrote:
> The uncore_collect_events functions assumes that event group
> might contain only uncore events which is wrong, because it
> might contain any type of events.
> 
> This bug leads to uncore framework touching 'not' uncore events,
> which could end up all sorts of bugs.

Thanks for tracking that down. Looks good to me.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/