linux-kernel - Re: [PATCH] staging: goldfish: Fix minor coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141213212051.GB6979@iron>
Date:	Sat, 13 Dec 2014 22:20:52 +0100
From:	Loic Pefferkorn <loic@...cp.eu>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Cc:	gregkh@...uxfoundation.org, alan@...ux.intel.com,
	jun.j.tian@...el.com, octavian.purdila@...el.com, nnk@...gle.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: goldfish: Fix minor coding style

On Sat, Dec 13, 2014 at 07:07:05PM +0000, One Thousand Gnomes wrote:
> 
> Pointless churn. It makes it less readable if anything, and it removes
> the type safety as you are now checking against 0 not (void *)0
> 
> NAK
> 
> Alan

The type safety is an interesting point I was not aware of.

Just in case, do you have something for me on your todo list?

-- 
Cheers,
Loïc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/