linux-kernel - Re: [PATCH] staging: goldfish: Fix minor coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141213194647.GA30065@hudson.localdomain>
Date:	Sat, 13 Dec 2014 11:46:47 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Loic Pefferkorn <loic@...cp.eu>
Cc:	gregkh@...uxfoundation.org, alan@...ux.intel.com,
	jun.j.tian@...el.com, octavian.purdila@...el.com, nnk@...gle.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: goldfish: Fix minor coding style

Loïc,

On Sat, Dec 13, 2014 at 07:22:38PM +0100, Loic Pefferkorn wrote:
> > Whose convention is this?  I can't find any mention in
> > Documention/CodingStyle. checkpatch.pl doesn't complain about them.
> > And there are almost three thousand examples in staging which don't
> > use this convention.
> > 
> >   linux-next$ grep -r "== NULL" drivers/staging/* | wc -l
> >   2844
> 
> Hi Jeremiah,
> 
> Thanks for your feedback.
> 
> I have used checkpatch.pl with the --strict flag:
> 
> $ ./scripts/checkpatch.pl --strict -f drivers/staging/goldfish/goldfish_nand.c
> CHECK: Comparison to NULL could be written "!cps"
> #51: FILE: drivers/staging/goldfish/goldfish_nand.c:51:
> +   if (cps == NULL)
> 
> CHECK: Comparison to NULL could be written "!name"
> #333: FILE: drivers/staging/goldfish/goldfish_nand.c:333:
> +   if (name == NULL)
> 
> CHECK: Comparison to NULL could be written "!r"
> #382: FILE: drivers/staging/goldfish/goldfish_nand.c:382:
> +   if (r == NULL)
> 
> CHECK: Comparison to NULL could be written "!base"
> #386: FILE: drivers/staging/goldfish/goldfish_nand.c:386:
> +   if (base == NULL)
> 
> CHECK: Comparison to NULL could be written "!nand"
> #402: FILE: drivers/staging/goldfish/goldfish_nand.c:402:
> +   if (nand == NULL)
> 
> total: 0 errors, 0 warnings, 5 checks, 442 lines checked
> 
> drivers/staging/goldfish/goldfish_nand.c has style problems, please review.
> 
> I have also found another commit having the same purpose: 7f376cd6dc1c9bfd14514c70765e6900a961c4b8
> 
> -- 
> Cheers,
> Loïc

It looks like you're right.  I must say I am surprised.  I had no idea
checkpatch.pl could be even more pedantic than it already is :-)

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/