linux-kernel - Re: [PATCH v4 1/6] iio: imu: Add support for Kionix KMX61 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZDcTAvf-98=BzZscqMhdhwychOzkEyejh4W_1A_9UBxNQ@mail.gmail.com>
Date:	Mon, 15 Dec 2014 12:50:43 +0200
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Hartmut Knaack <knaack.h@....de>
Cc:	Daniel Baluta <daniel.baluta@...el.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Peter Meerwald <pmeerw@...erw.net>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/6] iio: imu: Add support for Kionix KMX61 sensor

On Mon, Dec 15, 2014 at 12:43 AM, Hartmut Knaack <knaack.h@....de> wrote:
> Daniel Baluta schrieb am 03.12.2014 um 14:31:
>> Minimal implementation for KMX61 6-axis accelerometer/magnetometer. It exports
>> raw accel/magn readings together with scale and sampling frequency.
>>
>> This driver uses two IIO devices one for accelerometer and one for magnetometer.
>>
> Hi Daniel,
> I think you dropped slightly too much code. In kmx61_set_odr() you stored the set
> odr bits in data->odr_bits previously, but now it's gone. But kmx61_get_odr()
> accesses data->odr_bits, which now remains in the state from driver initialization.
> Other than that, it's looking good.

Hi Hartmut,

Good catch. I will send a patch asap.
Thanks for feedback!

Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/