| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Dec 2014 11:51:47 +0000 From: One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk> To: Loic Pefferkorn <loic@...cp.eu> Cc: devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: staging: goldfish: Fix minor coding style On Sat, 13 Dec 2014 22:20:52 +0100 Loic Pefferkorn <loic@...cp.eu> wrote: > On Sat, Dec 13, 2014 at 07:07:05PM +0000, One Thousand Gnomes wrote: > > > > Pointless churn. It makes it less readable if anything, and it removes > > the type safety as you are now checking against 0 not (void *)0 > > > > NAK > > > > Alan > > The type safety is an interesting point I was not aware of. > > Just in case, do you have something for me on your todo list? Depends what you feel confident tackling. An interesting but challenging one to look at as a newcomer might be https://bugzilla.kernel.org/show_bug.cgi?id=87951 because it provides you with an example .iso file you can loopback mount to see the crash, and the same fixes were done for a similar bug so can be seen in the git log to work from. commit 410dd3cf4c9b36f27ed4542ee18b1af5e68645a4 It's predictable, it's repeatable and it can be done crashing a virtual machine not a real one. That usually makes things eaiser to fix. For something easier perhaps https://bugzilla.kernel.org/show_bug.cgi?id=75111 which just needs the configuration help fixing Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists