linux-kernel - Re: How to fix CHECK warning: testing a 'safe expression' ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANeU7Q=85c8ehgCitG-Ujrr5O78V1yq9o=abJ8pwBBs0JOWAEg@mail.gmail.com>
Date:	Thu, 18 Dec 2014 10:39:08 +0800
From:	Christopher Li <sparse@...isli.org>
To:	Murali Karicheri <m-karicheri2@...com>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: How to fix CHECK warning: testing a 'safe expression' ?

On Thu, Dec 18, 2014 at 6:37 AM, Murali Karicheri <m-karicheri2@...com> wrote:
>         if (!ks_pcie) {
>                 dev_err(dev, "no memory for keystone pcie\n");
>                 return -ENOMEM;
>         }
>         pp = &ks_pcie->pp;
>
>         /* initialize SerDes Phy if present */
>         phy = devm_phy_get(dev, "pcie-phy");
> ===>    if (!IS_ERR_OR_NULL(phy)) {
>                 ret = phy_init(phy);
>                 if (ret < 0)
>                         return ret;
>

Hi,

Do you have a smaller stand alone test case which I can reproduce with sparse?

Thanks

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/